Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update laravel #625

Merged
merged 11 commits into from
Oct 23, 2024
Merged

chore: update laravel #625

merged 11 commits into from
Oct 23, 2024

Conversation

alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Sep 19, 2024

Summary

https://app.clickup.com/t/86dt2kdub

TODO:

  • fork and update the graham-campbell/analyzer dependency
  • make sure all missing dependencies have been re-added. They were removed initially to get laravel upgraded
  • fix any issues with dependencies
  • fix tests

So I've hit a snag on point 2:

  • vyuldashev/nova-permission is no longer supported - installing fork https://github.com/kiritokatklian/nova-permission with laravel 11 support requires laravel/nova:4.35.1 which requires auth that we don't have
  • can't install laravel/nova:4.33.0 which worked previously because that has dependency conflicts with brick/math, as a higher version is installed for laravel/framework:11

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I provided a screenshot of my changes to the component (if applicable)
  • I regenerated the icons.html file and checked if my newly added icon is shown correctly (if necessary)
  • I added an explanation on how to use the component to the readme (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alexbarnsley alexbarnsley marked this pull request as draft September 19, 2024 22:32
@alexbarnsley alexbarnsley marked this pull request as ready for review October 7, 2024 12:20
@alexbarnsley alexbarnsley changed the title [wip] chore: update laravel chore: update laravel Oct 7, 2024
@ItsANameToo ItsANameToo merged commit 89daa75 into main Oct 23, 2024
5 of 6 checks passed
@ItsANameToo ItsANameToo deleted the chore/update-laravel branch October 23, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants