Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Public Burn Function in erc721_bridgeable.cairo Limits Future Compatibility #229

Closed
ptisserand opened this issue Sep 25, 2024 · 7 comments
Assignees
Labels
app:cairo Work on the Starknet part of the application; you need to know Cairo lang. ODHack8

Comments

@ptisserand
Copy link
Collaborator

From https://codehawks.cyfrin.io/c/2024-07-ark-project/s/729

The erc721_bridgeable.cairo contract lacks a public burn function, which is essential for enabling token burning on Layer 2 (L2) in future updates, particularly with the planned useAutoBurn strategy.

@ptisserand ptisserand added app:cairo Work on the Starknet part of the application; you need to know Cairo lang. ODHack8 labels Sep 25, 2024
@saimeunt
Copy link
Contributor

@ptisserand Would love to work on this one, I have some experience in Cairo including ERC721Burnable logic 👌
https://github.com/carbonable-labs/cairo-erc-7498/blob/main/src/erc7498/interface.cairo#L47-L49

@mubarak23
Copy link
Contributor

mubarak23 commented Sep 26, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a Experience Cairo smart contract developer with experience working on projects such as Just Art Peace, Dojo, Kart, TBA, and Shinigami. Before transitioning to Cairo development, I was a backend developer specializing in Rust.

My recent work with cairo starknet

My recent work with rust

How I plan on tackling this issue

AS the issue describe, am going to add a function that enable enabling token burning on Layer 2 and also write test case for the function sure it’s work as expected.

ETH: 16HRS

@raizo07
Copy link

raizo07 commented Sep 26, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hello I'll like to be assigned to work on this.

I'm a software Dev with over four years experience and have worked on a couple of projects here. Here's a link to my profile https://app.onlydust.com/u/raizo07

@aji70
Copy link

aji70 commented Sep 26, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

i'm a solidity and cairo smart contract developer with over 2 years experience and believe i have the skill set for the task

How I plan on tackling this issue

i would create and add the burn function needed making it public to enhance the performance of the contract

@saimeunt
Copy link
Contributor

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Would love to work on this one, I have some experience in Cairo including ERC721Burnable logic 👌
https://github.com/carbonable-labs/cairo-erc-7498/blob/main/src/erc7498/interface.cairo#L47-L49

How I plan on tackling this issue

I will implement a burn function on ERC721Bridgeable and provide all the necessary tests.

Copy link

onlydustapp bot commented Sep 26, 2024

The maintainer ptisserand has assigned mubarak23 to this issue via OnlyDust Platform.
Good luck!

@ptisserand
Copy link
Collaborator Author

Closed by #243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:cairo Work on the Starknet part of the application; you need to know Cairo lang. ODHack8
Projects
None yet
Development

No branches or pull requests

5 participants