add burn function

[mubarak23]

PR for issue: #229

[vercel]

@mubarak23 is attempting to deploy a commit to the Screenshot Team on Vercel.

A member of the Team first needs to authorize it.

[ybensacq]

@mubarak23 could you keep the original formatting please ?

[mubarak23]

@mubarak23 could you keep the original formatting please ?

Am using eslint,

What formatting setup are you using for this project

[ptisserand]

Hi, unit tests are missing.

[mubarak23]

Hi, unit tests are missing.

alright, wanted to make sure the implementation is correct, before proceeding to the unit test,

i will push it right away

[ptisserand]

Hi, unit tests are missing.

alright, wanted to make sure the implementation is correct, before proceeding to the unit test,

i will push it right away

Hi @mubarak23 any update on this ?

[mubarak23]

Hi, unit tests are missing.

alright, wanted to make sure the implementation is correct, before proceeding to the unit test,
i will push it right away

Hi @mubarak23 any update on this ?

am having an issue with the test, i will fix it and push very soon

[mubarak23]

@ptisserand

this is my test function

    #[test]
fn burn_from_bridge() {
    let BRIDGE = bridge_addr_mock();
    
    let DUO_OWNER = starknet::contract_address_const::<128>();

    let contract_address = deploy_everai_collection();

    let erc721b = IERC721BridgeableDispatcher { contract_address };

    // Mint a token first to be able to burn it later
    start_prank(CheatTarget::One(contract_address), BRIDGE);
    erc721b.mint_from_bridge(DUO_OWNER, 42_u256);
    stop_prank(CheatTarget::One(contract_address));

    // Check that the owner is set correctly after minting
    let erc721 = IERC721Dispatcher { contract_address };
    assert!(erc721.owner_of(42_u256) == DUO_OWNER, "bad owner after mint");

    // Burn the token
    start_prank(CheatTarget::One(contract_address), BRIDGE);
    erc721b.burn(42_u256);
    stop_prank(CheatTarget::One(contract_address));

    // Verify that the token no longer exists
    let burn_result = erc721.owner_of(42_u256);
    assert!(burn_result == DUO_OWNER, "token should be burned, but still exists");
}

i keep getting the following error

Failure data:
    0x4552433732313a20696e76616c696420746f6b656e204944 ('ERC721: invalid token ID')

[ptisserand]

There is a really huge security issue to let anyone burn any token!
Please fix it

[ptisserand]

Thanks!
After tests renaming, it could be merged.

[ptisserand]

Thanks for your contribution