Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing events emit in bridge.cairo #232

Closed
ptisserand opened this issue Sep 25, 2024 · 7 comments · Fixed by #236
Closed

Add missing events emit in bridge.cairo #232

ptisserand opened this issue Sep 25, 2024 · 7 comments · Fixed by #236
Assignees
Labels
app:cairo Work on the Starknet part of the application; you need to know Cairo lang. ODHack8

Comments

@ptisserand
Copy link
Collaborator

The functions enable_white_list, set_bridge_l1_addr, set_erc721_class_hash and set_l1_l2_collection_mapping in bridge.cairo lacks of events emitting.

Unit test must be updated to add event check.

@ptisserand ptisserand added app:cairo Work on the Starknet part of the application; you need to know Cairo lang. ODHack8 labels Sep 25, 2024
@PavitraAgarwal21
Copy link

PavitraAgarwal21 commented Sep 25, 2024

@ptisserand love to take this up when OD hack start.

@saimeunt
Copy link
Contributor

@ptisserand Would love to work on this one, I have some experience in Cairo including unit testing 👌
https://github.com/carbonable-labs/cairo-erc-7498

@Mystic-Nayy
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Simplify core test file structure by moving tests in /src next to code

How I plan on tackling this issue

  1. Add event emissions to enable_white_list, set_bridge_l1_addr, set_erc721_class_hash, and set_l1_l2_collection_mapping in bridge.cairo.

  2. Include relevant parameters in the events for tracking changes.

  3. Update unit tests to verify the correct events are emitted with expected values.

@danielcdz
Copy link

danielcdz commented Sep 26, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hello, I'm Daniel Calderón!
I'm a passionate software engineer with over 3 years of experience, actively contributing to open-source projects through OnlyDust. I’m also a community moderator at Dojo Coding, where I help new developers get started with blockchain development.
Over the past few months, I've contributed to several Starknet projects, including cairo-vm-go by Nethermind. Currently, I’m a Cairo developer at ByteBuilders, working on ByteBeasts, a fully on-chain RPG game built using the Dojo Engine framework.
My expertise spans full-stack development, with a focus on backend, frontend, and smart contract development in blockchain ecosystems.

How I plan on tackling this issue

Currently, I'm building a fully on chain game using the Dojo Engine framework, I have good XP with unit testing on Cairo Smart Contracts!
I will use the starknet::testing utils to check if the events were emitted properly after applying the changes to the functions.

@aji70
Copy link

aji70 commented Sep 26, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

i'm a solidity and cairo smart contract developer with over 2 years experience and believe i have the skill set for the task

How I plan on tackling this issue

would create and add the missing events

@saimeunt
Copy link
Contributor

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Would love to work on this one, I have some experience in Cairo including unit testing 👌
https://github.com/carbonable-labs/cairo-erc-7498

How I plan on tackling this issue

I will make sure to emit the correct events and test that they were indeed emitted using snfoundry spy and assert_emitted.

Copy link

onlydustapp bot commented Sep 26, 2024

The maintainer ptisserand has assigned saimeunt to this issue via OnlyDust Platform.
Good luck!

@saimeunt saimeunt mentioned this issue Sep 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:cairo Work on the Starknet part of the application; you need to know Cairo lang. ODHack8
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants