-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing events emit in bridge.cairo #232
Comments
@ptisserand love to take this up when OD hack start. |
@ptisserand Would love to work on this one, I have some experience in Cairo including unit testing 👌 |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedSimplify core test file structure by moving tests in /src next to code How I plan on tackling this issue
|
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedHello, I'm Daniel Calderón! How I plan on tackling this issueCurrently, I'm building a fully on chain game using the Dojo Engine framework, I have good XP with unit testing on Cairo Smart Contracts! |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedi'm a solidity and cairo smart contract developer with over 2 years experience and believe i have the skill set for the task How I plan on tackling this issuewould create and add the missing events |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedWould love to work on this one, I have some experience in Cairo including unit testing 👌 How I plan on tackling this issueI will make sure to emit the correct events and test that they were indeed emitted using snfoundry spy and assert_emitted. |
The maintainer ptisserand has assigned saimeunt to this issue via OnlyDust Platform. |
The functions
enable_white_list
,set_bridge_l1_addr
,set_erc721_class_hash
andset_l1_l2_collection_mapping
inbridge.cairo
lacks of events emitting.Unit test must be updated to add event check.
The text was updated successfully, but these errors were encountered: