Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing events #236

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Add missing events #236

merged 2 commits into from
Sep 27, 2024

Conversation

saimeunt
Copy link
Contributor

@saimeunt saimeunt commented Sep 26, 2024 •
edited
Loading

Closes #232

  • Added the necessary event emissions in the bridge contract.
  • Added 4 new unit tests to make sure the setters work accordingly and emit the aforementioned events.

@vercel Vercel
Copy link

vercel bot commented Sep 26, 2024

@saimeunt is attempting to deploy a commit to the Screenshot Team on Vercel.

A member of the Team first needs to authorize it.

ptisserand
ptisserand requested changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@ptisserand ptisserand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, there are minor changes and then it should be good for merging.

apps/blockchain/starknet/src/interfaces.cairo Show resolved Hide resolved
apps/blockchain/starknet/src/interfaces.cairo Show resolved Hide resolved
apps/blockchain/starknet/src/tests/bridge_t.cairo Outdated Show resolved Hide resolved
@saimeunt
Copy link
Contributor Author

@ptisserand Thank you for your review, I made the requested changes. 👌

@ptisserand ptisserand added this pull request to the merge queue Sep 27, 2024
Merged via the queue into ArkProjectNFTs:main with commit b87e889 Sep 27, 2024
0 of 2 checks passed
@ptisserand
Copy link
Collaborator

Thanks a lot for your contribution!

This was referenced Oct 24, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptisserand ptisserand ptisserand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing events emit in bridge.cairo
2 participants
@saimeunt @ptisserand