-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate starknetId #218
feat: integrate starknetId #218
Conversation
@Marchand-Nicolas is attempting to deploy a commit to the Screenshot Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @Marchand-Nicolas, thanks for this PR :) I just tried the deployed version of your branch here: https://bridge-mainnet-g785qgwco-screenshotlabs.vercel.app/ |
I remember getting this kind of issue with jedi swap in my PR. Last time I just had to update starknet react, I'm going to try it |
@Marchand-Nicolas I'm just pushing a commit to update the lock file, because it is blocking the deployment |
@Marchand-Nicolas It's good for the name, thanks 👍🏽 I have this for the profile picture though: I don't think that I have an associated image to my address |
When no image is associated, a default image is still returned. But it's weird, it looks like the Image component doesn't want to show it. I can try to switch to a simple <img |
Hey @Marchand-Nicolas, I Just tried and it is showing me a starknet ID image even when there is no starknet id associated to the current address: |
Yes, it's normal, it's the default PFP for any address, it's showing the same on starknet.quest for example |
Oh ok, I think it's better to disable it if no starknet id linked yes 👍🏽 |
All good, thanks for the PR @Marchand-Nicolas! |
close: #217