Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate starknetId #218

Merged

Conversation

Marchand-Nicolas
Copy link
Contributor

close: #217
image
image

Copy link

vercel bot commented May 23, 2024

@Marchand-Nicolas is attempting to deploy a commit to the Screenshot Team on Vercel.

A member of the Team first needs to authorize it.

@remiroyc remiroyc requested a review from YohanTz May 23, 2024 15:13
YohanTz
YohanTz previously approved these changes May 23, 2024
Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bridge-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2024 9:16am
bridge-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2024 9:16am

@YohanTz
Copy link
Contributor

YohanTz commented May 23, 2024

Hey @Marchand-Nicolas, thanks for this PR :) I just tried the deployed version of your branch here: https://bridge-mainnet-g785qgwco-screenshotlabs.vercel.app/
I connected my argent wallet with a starknet id linked to it, but it is not showing in the connect wallet button, do you know why?

@Marchand-Nicolas
Copy link
Contributor Author

Hey @Marchand-Nicolas, thanks for this PR :) I just tried the deployed version of your branch here: https://bridge-mainnet-g785qgwco-screenshotlabs.vercel.app/ I connected my argent wallet with a starknet id linked to it, but it is not showing in the connect wallet button, do you know why?

I remember getting this kind of issue with jedi swap in my PR. Last time I just had to update starknet react, I'm going to try it

@YohanTz
Copy link
Contributor

YohanTz commented May 23, 2024

@Marchand-Nicolas I'm just pushing a commit to update the lock file, because it is blocking the deployment

@YohanTz
Copy link
Contributor

YohanTz commented May 23, 2024

@Marchand-Nicolas It's good for the name, thanks 👍🏽 I have this for the profile picture though:
Screenshot 2024-05-24 at 00 45 11

I don't think that I have an associated image to my address

@Marchand-Nicolas
Copy link
Contributor Author

Marchand-Nicolas commented May 23, 2024

@Marchand-Nicolas It's good for the name, thanks 👍🏽 I have this for the profile picture though: Screenshot 2024-05-24 at 00 45 11

I don't think that I have an associated image to my address

When no image is associated, a default image is still returned. But it's weird, it looks like the Image component doesn't want to show it. I can try to switch to a simple <img

@Marchand-Nicolas
Copy link
Contributor Author

Yes, we are getting
image
(the image is a SVG)

@YohanTz
Copy link
Contributor

YohanTz commented May 24, 2024

Hey @Marchand-Nicolas, I Just tried and it is showing me a starknet ID image even when there is no starknet id associated to the current address:
Screenshot 2024-05-24 at 20 09 54
(I have no Starknet ID associated to this address)

@Marchand-Nicolas
Copy link
Contributor Author

Marchand-Nicolas commented May 24, 2024

Hey @Marchand-Nicolas, I Just tried and it is showing me a starknet ID image even when there is no starknet id associated to the current address: Screenshot 2024-05-24 at 20 09 54 (I have no Starknet ID associated to this address)

Yes, it's normal, it's the default PFP for any address, it's showing the same on starknet.quest for example
image
If you prefer I can disable it if no starknetId is linked ?

@YohanTz
Copy link
Contributor

YohanTz commented May 25, 2024

Hey @Marchand-Nicolas, I Just tried and it is showing me a starknet ID image even when there is no starknet id associated to the current address: Screenshot 2024-05-24 at 20 09 54 (I have no Starknet ID associated to this address)

Yes, it's normal, it's the default PFP for any address, it's showing the same on starknet.quest for example image If you prefer I can disable it if no starknetId is linked ?

Oh ok, I think it's better to disable it if no starknet id linked yes 👍🏽

@YohanTz
Copy link
Contributor

YohanTz commented May 26, 2024

All good, thanks for the PR @Marchand-Nicolas!

@YohanTz YohanTz added this pull request to the merge queue May 26, 2024
Merged via the queue into ArkProjectNFTs:main with commit fa874a6 May 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Starknet ID in the app
2 participants