Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added _disableInitializers() in Bridge's constructor #254

Merged
merged 2 commits into from
Nov 7, 2024
Merged

added _disableInitializers() in Bridge's constructor #254

merged 2 commits into from
Nov 7, 2024

Conversation

SoarinSkySagar
Copy link
Contributor

@SoarinSkySagar SoarinSkySagar commented Oct 28, 2024 •
edited
Loading

Closes #225

Checklist

  • Created the constructor function calling the _disableInitializers()
  • Written the tests for the constructor function
  • Ran all tests and made sure all tests passing

@vercel Vercel
Copy link

vercel bot commented Oct 28, 2024

@SoarinSkySagar is attempting to deploy a commit to the Screenshot Team on Vercel.

A member of the Team first needs to authorize it.

@SoarinSkySagar SoarinSkySagar changed the title did the needed constructor function change and added the correspondin… added _disableInitializers() in Bridge's constructor Oct 29, 2024
@SoarinSkySagar
Copy link
Contributor Author

Hi @ptisserand, can you please review this PR

ptisserand
ptisserand approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@ptisserand ptisserand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution!

@ptisserand ptisserand added this pull request to the merge queue Nov 7, 2024
Merged via the queue into ArkProjectNFTs:main with commit a8d26f3 Nov 7, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptisserand ptisserand ptisserand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_disableInitializers is missing in Bridge’s constructor
2 participants
@SoarinSkySagar @ptisserand