Apply suggestions from code review

Co-authored-by: Filip Maciejewski <[email protected]>
ArmaForces · Jan 28, 2024 · 5b0cad9 · 5b0cad9
1 parent 7248bf1
commit 5b0cad9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/addons/civilian_statemachine/CivilianMovement.hpp b/addons/civilian_statemachine/CivilianMovement.hpp
@@ -38,7 +38,7 @@ class CivilianMovement {
         onStateLeaving = "";
         class InVehicle {
             targetState = "EnteredVehicle";
-            condition = "!((vehicle leader _this) isEqualTo (leader _this))";
+            condition = "(vehicle leader _this) isNotEqualTo (leader _this)";
             onTransition = "";
         };
     };

diff --git a/addons/civilian_statemachine/functions/fnc_getGroupVehicles.sqf b/addons/civilian_statemachine/functions/fnc_getGroupVehicles.sqf
@@ -18,12 +18,7 @@
 params ["_group"];
 
 // Get all group vehicles
-private _groupVehicles = [];
-{
-    private _vehicle = _x getVariable [QGVAR(ownedVehicle), objNull];
-    if (!isNull _vehicle) then {
-        _groupVehicles pushBackUnique _vehicle;
-    };
-} forEach (units _group);
+private _groupVehicles = units _group apply {_x getVariable [QGVAR(ownedVehicle), objNull]} select {!isNull _x};
+_groupVehicles arrayIntersect _groupVehicles // return
 
 _groupVehicles