Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully localize all user visible actions, messages, notifications and fix related bugs #96

Merged
merged 55 commits into from
Apr 15, 2024
Merged

Fully localize all user visible actions, messages, notifications and fix related bugs #96

merged 55 commits into from
Apr 15, 2024

Conversation

3Mydlo3
Copy link
Member

@3Mydlo3 3Mydlo3 commented Apr 7, 2024 •
edited
Loading

When merged this pull request will:

  • title
  • Fix cannot create vehicle message appearing when an empty vehicle is deleted and new one could be spawned immediately instead of requiring another spawn request from player
  • Fix killers start module "LocationName" property had no name or tooltip
  • Remove all forced "LocationName" settings from police station and killers start modules in all provided scenarios
    • Automatic solution now exists which will provide localized names for every player
  • Add which cop killed other cop to the message
  • Fix cop killed by cop detection that fired when civilians killed cops (that happened a lot)
  • Localize car alarm notification
  • Fix time limit and extra time (didn't work at all)

3Mydlo3 added 30 commits January 28, 2024 18:27
@3Mydlo3
Replace placeholders
631eec0
@3Mydlo3
Variable location size so kill messages better reflect in/around for …
ad3f900 
…large cities
@3Mydlo3
Merge remote-tracking branch 'origin/master' into feature/localize-ki…
f743cc8 
…ll-messages
@3Mydlo3
Adjust for cityArea
2cb8959
@3Mydlo3
Fix Civilian killed stringtable
83e45de
@3Mydlo3
Optimize killed marker creation
4c219e3
@3Mydlo3
Prevent 'cop killed by cop' when civilian kills cop
bdcbf3b
@3Mydlo3
Fix localization of kill notifications
7d15f7e
@3Mydlo3
Show localized car alarm notification
b3caccb
@3Mydlo3
Localize cannot create vehicle message
be4d353
@3Mydlo3
Fix some settings should not require restart
196f8ec
@3Mydlo3
Fix alarm not working in nearby civilians mode
5ee9b37
@3Mydlo3
Add TODO
79e77d9
@3Mydlo3
Merge remote-tracking branch 'origin/master' into feature/localize-me…
257cec8 
…ssages
@3Mydlo3
Localize killers start positions names
12465fb
@3Mydlo3
Fix incorrect PREP
b3b664d
@3Mydlo3
Change locationNames(Raw) namespaces to hashMaps
af277ff
@3Mydlo3
Fix default LocationName for module not being localized
d991536
@3Mydlo3
Fix for generated positions
4e72f39
@3Mydlo3
Optimize policeStationMarker creation
3839528
@3Mydlo3
Localize "Teleport back"
cbba9ed
@3Mydlo3
Add FUNC(isCop)
b96c00d
@3Mydlo3
Fix logging player or AI
6c67ed9
@3Mydlo3
Fix again
2bb795f
@3Mydlo3
Fix side check in isCop
03984cc
@3Mydlo3
Try workaround for vehicle suicide detection
43cc417
@3Mydlo3
Add name of the cop that killed other cop
3eb5190
@3Mydlo3
Fix variable name
61d79d9
@3Mydlo3
Fix cop check in kill messages
7346c3a
@3Mydlo3
Fix killer name being null on suicide
c059d01
@3Mydlo3 3Mydlo3 added enhancement New feature or request bugfix Fixes something wasn't working labels Apr 7, 2024
@3Mydlo3 3Mydlo3 added this to the 1.0.0.0 milestone Apr 7, 2024
3Mydlo3 added 16 commits April 9, 2024 00:35
@3Mydlo3
Fix killers don't see police station markers
8a6bc66
@3Mydlo3
Merge remote-tracking branch 'origin/master' into feature/full-locali…
0a11386 
…zation
@3Mydlo3
Try localize 'maximum idle time reached'
79701bb
@3Mydlo3
Localize teleport name
59fbd1b
@3Mydlo3
Use isNotEqualTo
a50935f
@3Mydlo3
PublicVariable LocationName of police station module
f2d95b9
@3Mydlo3
Pass unlocalized string to changeScore for timeout message
bb9e205
@3Mydlo3
Fix localizable message template and args ignored in showScore flow
0b705b2
@3Mydlo3
Still doesn't work
ae60cc0
@3Mydlo3
Fix format array creation
c51d3d3
@3Mydlo3
Add postInit warning message that debug mode is enabled
d9f9da9
@3Mydlo3
Actually implement time limit
f6affbb
@3Mydlo3
Change killers score change stacking duration the more score changes
f048ecb
@3Mydlo3
Time limit & extra time improvements
f1f32d8
@3Mydlo3
Shorten main game time limit to 30 minutes (+15 extra)
bca0f02
@3Mydlo3
Increase extra time timeouts limit
00b05b0
@3Mydlo3 3Mydlo3 merged commit 4004b52 into master Apr 15, 2024
2 checks passed
@3Mydlo3 3Mydlo3 deleted the feature/full-localization branch April 15, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix Fixes something wasn't working enhancement New feature or request
Projects
Initial Release
Status: Done
Milestone
1.0.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@3Mydlo3