Release 1.18.0

.docker/Dockerfile

@@ -1,26 +1,35 @@
 # the different stages of this Dockerfile are meant to be built into separate images
 # https://docs.docker.com/compose/compose-file/#target
 
-ARG PHP_VERSION=8.0
+ARG PHP_VERSION=8.2
 ARG NGINX_VERSION=1.17
 
 # Build assets in disposable node image
-FROM node:11-alpine as armaforces_web_assets
+FROM node:18-alpine as armaforces_web_assets
 
 WORKDIR /tmp/app_build
 
-COPY package.json package-lock.json webpack.config.js ./
+COPY --link package.json package-lock.json webpack.config.js ./
 RUN npm install
 
 WORKDIR /tmp/app_build/assets/
 
-COPY assets ./
+COPY --link assets ./
 RUN npm run build:ci
 
 
 # Build PHP application image
 FROM php:${PHP_VERSION}-fpm-alpine AS armaforces_web_php
 
+# build for production
+ENV APP_ENV=prod
+
+WORKDIR /www/app
+
+# php extensions installer: https://github.com/mlocati/docker-php-extension-installer
+COPY --from=mlocati/php-extension-installer --link /usr/bin/install-php-extensions /usr/local/bin/
+
+# persistent / runtime deps
 RUN apk add --no-cache \
         acl \
         fcgi \
@@ -29,63 +38,33 @@ RUN apk add --no-cache \
         git \
     ;
 
-ARG APCU_VERSION=5.1.18
 RUN set -eux; \
-    apk add --no-cache --virtual .build-deps \
-        $PHPIZE_DEPS \
-        icu-dev \
-        libzip-dev \
-        zlib-dev \
-        postgresql-dev \
-    ; \
-    \
-    docker-php-ext-configure zip; \
-    docker-php-ext-install -j$(nproc) \
+    install-php-extensions \
         intl \
         zip \
-        pdo_pgsql \
-    ; \
-    pecl install \
-        apcu-${APCU_VERSION} \
-    ; \
-    pecl clear-cache; \
-    docker-php-ext-enable \
         apcu \
         opcache \
-    ; \
-    \
-    runDeps="$( \
-        scanelf --needed --nobanner --format '%n#p' --recursive /usr/local/lib/php/extensions \
-            | tr ',' '\n' \
-            | sort -u \
-            | awk 'system("[ -e /usr/local/lib/" $1 " ]") == 0 { next } { print "so:" $1 }' \
-    )"; \
-    apk add --no-cache --virtual .api-phpexts-rundeps $runDeps; \
-    \
-    apk del .build-deps \
-;
-
-COPY --from=composer/composer:2-bin /composer /usr/bin/composer
-RUN ln -s $PHP_INI_DIR/php.ini-production $PHP_INI_DIR/php.ini
-COPY .docker/php/conf.d/armaforces-web.ini $PHP_INI_DIR/conf.d/armaforces-web.ini
+        pdo_pgsql \
+    ;
+
+RUN mv "$PHP_INI_DIR/php.ini-production" "$PHP_INI_DIR/php.ini"
+COPY --link .docker/php/conf.d/armaforces-web.ini $PHP_INI_DIR/conf.d/
+COPY --link .docker/php/conf.d/armaforces-web.prod.ini $PHP_INI_DIR/conf.d/
 
 # https://getcomposer.org/doc/03-cli.md#composer-allow-superuser
 ENV COMPOSER_ALLOW_SUPERUSER=1
 ENV PATH="${PATH}:/root/.composer/vendor/bin"
 
-WORKDIR /www/app
-
-# build for production
-ARG APP_ENV=prod
+COPY --from=composer/composer:2-bin --link /composer /usr/bin/composer
 
 # prevent the reinstallation of vendors at every changes in the source code
 COPY composer.json composer.lock symfony.lock .env ./
 RUN set -eux; \
-    composer install --prefer-dist --no-dev --no-scripts --no-progress --no-suggest; \
+    composer install --prefer-dist --no-dev --no-scripts --no-progress; \
     composer clear-cache
 
 # copy only specifically what we need
-COPY bin bin/
+COPY --link bin bin/
 COPY config config/
 COPY migrations migrations/
 COPY public public/
@@ -98,12 +77,11 @@ RUN set -eux; \
     composer dump-autoload --classmap-authoritative --no-dev; \
     composer run-script --no-dev post-install-cmd; \
     chmod +x bin/console; sync
-VOLUME /www/app/var
 
 # copy assets manifests
 COPY --from=armaforces_web_assets /tmp/app_build/public/build/ public/build/
 
-COPY .docker/php/docker-entrypoint.sh /usr/local/bin/docker-entrypoint
+COPY --link .docker/php/docker-entrypoint.sh /usr/local/bin/docker-entrypoint
 RUN chmod +x /usr/local/bin/docker-entrypoint
 
 # .env is copied again as COPY needs to copy at least one file
@@ -130,20 +108,23 @@ CMD ["nginx", "-g", "daemon off;"]
 
 FROM armaforces_web_php AS armaforces_web_php_dev
 
-ARG XDEBUG_VERSION=3.1.1
+ENV APP_ENV=dev
+#VOLUME /www/app/var/
+
+RUN rm $PHP_INI_DIR/conf.d/app.prod.ini; \
+	mv "$PHP_INI_DIR/php.ini" "$PHP_INI_DIR/php.ini-production"; \
+	mv "$PHP_INI_DIR/php.ini-development" "$PHP_INI_DIR/php.ini"
+
 RUN set -eux; \
-    apk add --no-cache --virtual .build-deps $PHPIZE_DEPS; \
-    pecl install xdebug-$XDEBUG_VERSION; \
-    docker-php-ext-enable xdebug; \
-    apk del .build-deps
+	install-php-extensions xdebug
 
 RUN apk add --no-cache \
         nodejs \
         npm
 
 ENV XDEBUG_INI_PATH=$PHP_INI_DIR/conf.d/docker-php-ext-xdebug.ini
-COPY .docker/php/conf.d/docker-php-ext-xdebug.ini $XDEBUG_INI_PATH
+COPY --link .docker/php/conf.d/docker-php-ext-xdebug.ini $XDEBUG_INI_PATH
 
-COPY .docker/php/scripts/xon.sh /usr/bin/xon
-COPY .docker/php/scripts/xoff.sh /usr/bin/xoff
+COPY --link .docker/php/scripts/xon.sh /usr/bin/xon
+COPY --link .docker/php/scripts/xoff.sh /usr/bin/xoff
 RUN chmod +x /usr/bin/xon /usr/bin/xoff

.docker/php/conf.d/armaforces-web.ini

@@ -1,13 +1,14 @@
-# Borrowed from https://github.com/api-platform/api-platform/blob/master/api/docker/php/conf.d/api-platform.ini
-
-apc.enable_cli = 1
+# Borrowed from https://github.com/api-platform/api-platform/blob/6ddd494ccec4dc5d0329c1ded75101e58b8747e4/api/docker/php/conf.d/app.ini
+expose_php = 0
 date.timezone = Europe/Warsaw
-session.auto_start = Off
-short_open_tag = Off
+apc.enable_cli = 1
+session.use_strict_mode = 1
+zend.detect_unicode = 0
 
-# http://symfony.com/doc/current/performance.html
+; https://symfony.com/doc/current/performance.html
+realpath_cache_size = 4096K
+realpath_cache_ttl = 600
 opcache.interned_strings_buffer = 16
 opcache.max_accelerated_files = 20000
 opcache.memory_consumption = 256
-realpath_cache_size = 4096K
-realpath_cache_ttl = 600
+opcache.enable_file_override = 1

.docker/php/conf.d/armaforces-web.prod.ini

@@ -0,0 +1,2 @@
+;opcache.preload_user = www-data
+;opcache.preload = /www/app/config/preload.php

.docker/php/docker-entrypoint.sh

@@ -9,19 +9,17 @@ if [ "${1#-}" != "$1" ]; then
 fi
 
 if [ "$1" = 'php-fpm' ] || [ "$1" = 'php' ] || [ "$1" = 'bin/console' ]; then
-    PHP_INI_RECOMMENDED="$PHP_INI_DIR/php.ini-production"
-    if [ "$APP_ENV" != 'prod' ]; then
-        PHP_INI_RECOMMENDED="$PHP_INI_DIR/php.ini-development"
-    fi
-    ln -sf "$PHP_INI_RECOMMENDED" "$PHP_INI_DIR/php.ini"
-
-    mkdir -p var/cache var/log
     setfacl -R -m u:www-data:rwX -m u:"$(whoami)":rwX var || true
     setfacl -dR -m u:www-data:rwX -m u:"$(whoami)":rwX var || true
 
+    if [ "$APP_ENV" = 'dev' ]; then
+        composer install --prefer-dist --no-progress --no-interaction || true
+    fi
+
     if [ "$APP_ENV" = 'prod' ]; then
         php bin/console doctrine:migrations:migrate --allow-no-migration --no-interaction
     fi
+
 fi
 
 exec docker-php-entrypoint "$@"

.env

@@ -9,6 +9,7 @@
 # Real environment variables win over .env files.
 #
 # DO NOT DEFINE PRODUCTION SECRETS IN THIS FILE NOR IN ANY OTHER COMMITTED FILES.
+# https://symfony.com/doc/current/configuration/secrets.html
 #
 # Run "composer dump-env prod" to compile .env files for production use (requires symfony/flex >=1.2).
 # https://symfony.com/doc/current/best_practices.html#use-environment-variables-for-infrastructure-configuration
@@ -43,10 +44,6 @@ APP_SECRET=3c0e1589d36f2c28609e4ec5af60f545
 DATABASE_URL="postgresql://user:password@pgsql:5432/af_website?serverVersion=16&charset=utf8"
 ###< doctrine/doctrine-bundle ###
 
-###> symfony/mailer ###
-# MAILER_DSN=smtp://localhost
-###< symfony/mailer ###
-
 ###> nelmio/cors-bundle ###
 CORS_ALLOW_ORIGIN='^https?://(localhost|127\.0\.0\.1)(:[0-9]+)?$'
 ###< nelmio/cors-bundle ###

.env.test

@@ -1,12 +1,12 @@
 # define your env variables for the test env here
 KERNEL_CLASS='App\Kernel'
 APP_SECRET='$ecretf0rt3st'
-SYMFONY_DEPRECATIONS_HELPER=999999
+SYMFONY_DEPRECATIONS_HELPER=weak
 PANTHER_APP_ENV=panther
 PANTHER_ERROR_SCREENSHOT_DIR=./var/error-screenshots
 
-APP_SECURITY_OAUTH_DISCORD_SERVER_ID=1
+APP_SECURITY_OAUTH_DISCORD_SERVER_ID=
 
 APP_SECURITY_API_ALLOWED_KEYS=test_key
 
-APP_URL_TEAMSPEAK='teamspeak.example.com'
+APP_URL_TEAMSPEAK='ts3server://ts.localhost.com?password=test'

.github/workflows/application.yml

@@ -26,21 +26,27 @@ jobs:
 
             -   name: Start stack
                 run: |
-                    docker-compose -f docker-compose.test.yml up -d
-                    docker-compose exec -T php composer install
+                    docker compose -f docker-compose.test.yml up --wait
+                    docker compose exec -T php composer install
 
-            -   name: Setup database
+            -   name: Setup tests
                 run: |
-                    make db env=test
+                    make test-setup
 
             -   name: Run lint
                 run: |
-                    docker-compose exec -T php bin/console cache:warmup --env=dev
+                    docker compose exec -T php bin/console cache:warmup --env=dev
                     make cs env=test ci=true
 
             -   name: Run tests
                 run: |
-                    make test-ci
+                    make test
+
+            -   name: Failure logs
+                if: failure()
+                run: |
+                    docker compose logs php
+                    docker compose logs mysql
 
     docker_release:
         name: Docker release

.gitignore

@@ -1,6 +1,7 @@
-/.idea
-/VERSION
+# IDEs
+.idea
 
+/VERSION
 fos_js_routes.js
 public/img/background
 
@@ -14,16 +15,16 @@ public/img/background
 /vendor/
 ###< symfony/framework-bundle ###
 
-###> symfony/phpunit-bridge ###
-.phpunit.result.cache
-/phpunit.xml
-###< symfony/phpunit-bridge ###
-
 ###> phpunit/phpunit ###
 /phpunit.xml
 .phpunit.result.cache
 ###< phpunit/phpunit ###
 
+###> symfony/phpunit-bridge ###
+.phpunit.result.cache
+/phpunit.xml
+###< symfony/phpunit-bridge ###
+
 ###> symfony/webpack-encore-bundle ###
 /node_modules/
 /public/build/

.php-cs-fixer.dist.php

@@ -3,6 +3,7 @@
 declare(strict_types=1);
 
 $finder = PhpCsFixer\Finder::create()
+    ->in(__DIR__)
     ->exclude('var')
     ->exclude('node_modules')
     ->notPath('config/bundles.php')
@@ -11,7 +12,11 @@
     ->notPath('public/index.php')
     ->notPath('src/Kernel.php')
     ->notPath('tests/bootstrap.php')
-    ->in(__DIR__)
+
+    # Codeception
+    ->exclude('tests/_data')
+    ->exclude('tests/_output')
+    ->exclude('tests/_support/_generated')
 ;
 
 return (new PhpCsFixer\Config())
@@ -26,12 +31,11 @@
         '@PHP80Migration' => true,
         '@PHP80Migration:risky' => true,
 
-        'php_unit_test_annotation' => [
-            'style' => 'annotation',
-        ],
+        'php_unit_internal_class' => false,
         'php_unit_method_casing' => false,
+        'php_unit_test_class_requires_covers' => false,
+        'phpdoc_separation' => false,
         'phpdoc_to_comment' => false,
-        'ordered_traits' => false,
         'ordered_class_elements' => [
             'order' => [
                 'use_trait', // traits
@@ -64,7 +68,6 @@
             ],
             'sort_algorithm' => 'none',
         ],
-        'phpdoc_separation' => false
     ])
     ->setFinder($finder)
 ;