Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small correction to calibration and change tool #252

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

weemantella
Copy link
Contributor

@weemantella weemantella commented Feb 5, 2025

Major Changes in this PR

  • changed default hub_clear_move_dis to avoid too much retraction during lane change
  • corrected lack on None check in calibration

Notes to Code Reviewers

How the changes in this PR are tested

  • run calibration
  • change lanes

PR Checklist: (Checked-off items are either done or do not apply to this PR)

  • I have performed a self-review of my code
  • CHANGELOG.md is updated (if end-user facing)
  • Sent notification to software-design channel requesting review

@weemantella weemantella marked this pull request as ready for review February 5, 2025 03:20
return

if afc_bl not in self.AFC.lanes:
self.AFC.ERROR.AFC_error("{} not a valid lane".format(afc_bl), pause=False)
if afc_bl is not None not in self.AFC.lanes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to have and afc_bl not in

@MG-longshot MG-longshot merged commit 7fee640 into ArmoredTurtle:main Feb 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants