New filter options, owner aditions and feedback #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wing the name of the owner of the review
…n marker popup and added filters to my locations and friend locations.
UO278249
added
enhancement:up::arrow_up:
UO278249
requested review from
MarioP-Dev,
Elias-Llera,
silSuarezP,
UO276188 and
uo276670
|
The new parts seem to be working correclty but I am getting an error with our type MapMarker:
The new box for the owner of the location doesnt correctly match the popUp box |
|
Also we will need some twicking on the filters. Right now the names are confusing. My location, Public locations, Friend locations seems a little bit confusing
Also it could be great If we could have on one column the list with the types, monument, sight, etc... and then another column with the other kind of filters like, my locations and friends locations |
…and now trying to make a marker without name makes a warning popup show without exiting the form.
…ew image display on add review form.
# Conflicts: # webapp/src/components/FriendsPage/FriendsView.tsx # webapp/src/components/Map.tsx
|
Branch updated due to comments filter changed and some more corrections and small aditions have been added. |
UO278249
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been multiple changes on the map view: