Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature share routes - Notifications #125

Merged
merged 9 commits into from
Apr 1, 2020
Merged

Conversation

Drastur
Copy link
Contributor

@Drastur Drastur commented Apr 1, 2020

This solves part of #116, as we wait for a final conclusion in ViadeSpec. Also provides friend listing mentioned in #55.

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #125 into development will decrease coverage by 9.53%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #125      +/-   ##
===============================================
- Coverage        43.51%   33.98%   -9.54%     
===============================================
  Files               25       28       +3     
  Lines              239      515     +276     
  Branches            10       31      +21     
===============================================
+ Hits               104      175      +71     
- Misses             129      317     +188     
- Partials             6       23      +17     
Impacted Files Coverage Δ
src/components/navBar/navBar.js 11.11% <0.00%> (-5.56%) ⬇️
src/components/routeList/RouteCard.js 100.00% <ø> (ø)
src/model/MyRoute.js 38.80% <0.00%> (-4.53%) ⬇️
src/pages/ShareView.js 0.00% <0.00%> (ø)
src/components/navBar/navBarNotAuthenticated.js 57.14% <0.00%> (-42.86%) ⬇️
src/components/routeList/RouteList.js 60.00% <0.00%> (-30.91%) ⬇️
src/components/podService/podStoreHandler.js 6.12% <0.00%> (-5.88%) ⬇️
src/pages/Home.js 16.66% <0.00%> (-5.56%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2129a41...3198d62. Read the comment docs.

Copy link
Contributor

@oscar134 oscar134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good

@Drastur Drastur merged commit 1a19103 into development Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants