Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions prepared for game ending and fixed bug at answering time exhaustion #116

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

ChristianFN2
Copy link
Contributor

  • Questions are now fetched in batches of 10 (Controllable with a constant variable) and the system is prepared to identify and manage the game ending (For now it is set to just loop and get another batch of 10 but in the future it will end the game with some feedback).

As a consequence, the user only has to wait to answer when questions are first generated, and not between questions

@ChristianFN2 ChristianFN2 linked an issue Apr 11, 2024 that may be closed by this pull request
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
56.4% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

@adriiglz
Copy link
Contributor

adriiglz commented Apr 14, 2024

Great contribution christian. Would it be possible to achieve >65% code coverage? I mean, implementing some tests for this functionallity so we already have some tests passing for it

@ChristianFN2
Copy link
Contributor Author

Of course @adriiglz , I will have 80%+ coverage for this week, although we will talk about it in today's meeting.

@adriiglz adriiglz merged commit 8b1c043 into develop Apr 15, 2024
1 of 2 checks passed
@ChristianFN2 ChristianFN2 deleted the questions-enhancement branch April 17, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abnormal generation of questions when time runs out
2 participants