Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question fetching time significantly reduced and now player cannot answer if time is not running #125

Merged
merged 6 commits into from
Apr 24, 2024

Conversation

ChristianFN2
Copy link
Contributor

Now questions are fetched asynchronously and it is checked if the time has started before the player can answer.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@andrrsin andrrsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and i love the hotfix on the tests

@andrrsin andrrsin merged commit 21260f7 into develop Apr 24, 2024
1 of 2 checks passed
@andrrsin andrrsin deleted the questions-performance&fix branch April 24, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Player can answer when questions have not loaded Question fetching time is too much
2 participants