Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend for rankings #40

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Backend for rankings #40

merged 3 commits into from
Mar 8, 2024

Conversation

adriiglz
Copy link
Contributor

@adriiglz adriiglz commented Mar 8, 2024

Added the endpoint for the rankings functionallity and changed User's schema (now it includes 'points' field)

@andrrsin
Copy link
Contributor

andrrsin commented Mar 8, 2024

Hey as we have talked we will use localStirage in the front end rather than using cookies, so maybe we can cancel these changes and we will adapt it later!!

@adriiglz
Copy link
Contributor Author

adriiglz commented Mar 8, 2024

Ready, token is no longer stored as a cookie

Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
18.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@adriiglz
Copy link
Contributor Author

adriiglz commented Mar 8, 2024

SonarCloud test failed because user points are generated randomly. This is for this early stage, only for testing the rankings functionallity

@adriiglz adriiglz added the Enhancement ✴️ New feature or request label Mar 8, 2024
Copy link
Contributor

@andrrsin andrrsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right!

@@ -19,6 +19,7 @@
"homepage": "https://github.com/arquisoft/wiq_en1a#readme",
"dependencies": {
"axios": "^1.6.5",
"cookie-parser": "^1.4.6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We weill leave the library as we may need it furhgter. PAckage management to prevent unused packages, etc will be done further in the project

@andrrsin andrrsin merged commit 7d5b21d into develop Mar 8, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✴️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants