New approach to try to solve the warnings

Arquisoft · Apr 13, 2024 · 278116f · 278116f
1 parent aa30e31
commit 278116f
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 16 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -44,5 +44,5 @@ jobs:
     - run: npm --prefix users/userservice install
     - run: npm --prefix gatewayservice install
     - run: npm --prefix webapp install
-    - run: process.env.CI=false npm --prefix webapp run build
+    - run: npm --prefix webapp run build
     - run: npm --prefix webapp run test:e2e
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -43,7 +43,7 @@ jobs:
     - run: npm --prefix users/userservice install
     - run: npm --prefix gatewayservice install
     - run: npm --prefix webapp install
-    - run: process.env.CI=false npm --prefix webapp run build
+    - run: npm --prefix webapp run build
     - run: npm --prefix webapp run test:e2e
   docker-push-webapp:
     name: Push webapp Docker Image to GitHub Packages

diff --git a/webapp/src/components/HistoricalData/HistoricalView.js b/webapp/src/components/HistoricalData/HistoricalView.js
@@ -1,4 +1,4 @@
-import React, {useEffect, useState } from 'react';
+import React, { useState } from 'react';
 import {useTranslation} from "react-i18next";
 import HistoryRecordRetriever from './HistoryRecordRetriever';
 import { useUserContext } from '../loginAndRegistration/UserContext'; 
@@ -10,20 +10,23 @@ const retriever = new HistoryRecordRetriever();
 
 
 export default function HistoricalView() {
-  const [records, setRecords]= useState([]);
+  const [records, setRecords]= useState(null);
   const[t] = useTranslation("global");
   const {user} = useUserContext();
 
-    const getRecords = async ()=>{
-          try {
-              var jsonRecords = await retriever.getRecords(user.username); 
-              var recordsArray = jsonRecords.games;
-              setRecords(recordsArray);
-          } catch (error) {
-              console.log(error);
-          }
+  const getRecords = async ()=>{
+        try {
+            var jsonRecords = await retriever.getRecords(user.username); 
+            var recordsArray = jsonRecords.games;
+            setRecords(recordsArray);
+        } catch (error) {
+            console.log(error);
+        }
   }
-  useEffect(() => {getRecords()}, []);
+
+  if(records === null)
+    getRecords();
+
   return (
     <div className='globalHistoricalView'>
       {(records && records.length !== 0) ? records.map((record, index) => (

diff --git a/webapp/src/components/questionView/QuestionView.js b/webapp/src/components/questionView/QuestionView.js
@@ -1,6 +1,6 @@
 import QuestionGenerator from './QuestionGenerator';
 import CreationHistoricalRecord from './CreationHistoricalRecord';
-import { useEffect, useState } from 'react';
+import { useState } from 'react';
 import "../../custom.css";
 import React from "react";
 import Countdown from 'react-countdown';
@@ -15,7 +15,7 @@ const questionGenerator = new QuestionGenerator();
 var points = 0;
 function QuestionView(){
     const [numQuestion, setnumQuestion] = useState(-1);
-    const [questions, setQuestions] = useState([]);
+    const [questions, setQuestions] = useState(null);
     const[t, i18n] = useTranslation("global");
     const {user} = useUserContext();
 
@@ -98,7 +98,9 @@ function QuestionView(){
 
     }
 
-    useEffect(() => {generateQuestions(numQuestion)}, []);
+    if(questions === null)
+        generateQuestions(numQuestion)
+
 
     return (
     <div className="question-view-container">