Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility #125

Merged
merged 15 commits into from
Apr 27, 2024
Merged

Accessibility #125

merged 15 commits into from
Apr 27, 2024

Conversation

lauratbg
Copy link
Contributor

@lauratbg lauratbg commented Apr 24, 2024

In this pr it is removed the tiktak sound, updated the instructions, the voice also reads the answers and player can answer by keyboard
Also solved the bug to not be able to change the language during the game

@lauratbg lauratbg requested a review from uo289267 April 24, 2024 19:26
@lauratbg lauratbg self-assigned this Apr 24, 2024
@lauratbg lauratbg linked an issue Apr 24, 2024 that may be closed by this pull request
@lauratbg lauratbg marked this pull request as draft April 25, 2024 12:17
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
52.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@lauratbg lauratbg requested a review from Mister-Mario April 26, 2024 15:48
@lauratbg lauratbg marked this pull request as ready for review April 26, 2024 15:48
Copy link
Contributor

@Mister-Mario Mister-Mario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough, the coverage will balance

@Mister-Mario Mister-Mario merged commit 40e18d3 into master Apr 27, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try to do more accessible the app
2 participants