Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed sonar call on e2e #166

Merged
merged 2 commits into from
Apr 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,4 @@ jobs:
- run: npm --prefix gatewayservice install
- run: npm --prefix webapp install
- run: npm --prefix webapp run build
- run: npm --prefix webapp run test:e2e
- name: Analyze with SonarCloud
uses: sonarsource/sonarcloud-github-action@master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
- run: npm --prefix webapp run test:e2e
5 changes: 5 additions & 0 deletions webapp/e2e/features/FeaturesToAdd.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Home:
Scenario: Closing the text container
Given I am on the home page
When I click on the toggle button to open and then I click it to close
Then The text container should be visible
7 changes: 1 addition & 6 deletions webapp/e2e/features/home.feature
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,4 @@ Feature: Home page functionality
Scenario: Opening the text container
Given I am on the home page
When I click on the toggle button to open
Then The text container should be hidden

Scenario: Closing the text container
Given I am on the home page
When I click on the toggle button to open and then I click it to close
Then The text container should be visible
Then The text container should be hidden
6 changes: 3 additions & 3 deletions webapp/e2e/steps/home.steps.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,13 @@ defineFeature(feature, test => {
await expect(page).toMatchElement('.text-container.hidden');
});
});

/*
test('Closing the text container', ({ given, when, then }) => {
given('I am on the home page', async () => {
await page.goto('http://localhost:3000/home');
await page.waitForSelector('.general');
});
when('I click on the toggle button to open and then I click it to close', async () => {
when('I click on the toggle button to open and then I click it to close', async () => {

await page.click('label[for="toggleOpen"]');

Expand All @@ -65,7 +65,7 @@ defineFeature(feature, test => {
then('The text container should be visible', async () => {
await expect(page).toMatchElement('.text-container.visible');
});
});
});*/

afterAll(async () => {
await browser.close();
Expand Down