Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished user managment #92

Merged
merged 23 commits into from
Apr 22, 2024
Merged

Finished user managment #92

merged 23 commits into from
Apr 22, 2024

Conversation

Mister-Mario
Copy link
Contributor

No description provided.

@Mister-Mario Mister-Mario linked an issue Apr 14, 2024 that may be closed by this pull request
@Mister-Mario Mister-Mario self-assigned this Apr 14, 2024
users/authservice/auth-service.js Fixed Show fixed Hide fixed
users/authservice/auth-service.js Fixed Show fixed Hide fixed
users/userservice/user-service.js Fixed Show fixed Hide fixed
const amount = req.params.amount.toString();
const type = req.params.type.toString();
// Forward the question request to the quetion service
const questionResponse = await axios.get(questionServiceUrl+'/questions/' + lang + '/' + amount + '/' + type);

Check warning

Code scanning / SonarCloud

Server-side requests should not be vulnerable to forging attacks Medium

Change this code to not construct the URL from user-controlled data. See more on SonarCloud
try {
const user = req.params.user;
// Forward the record request to the record service
const recordResponse = await axios.get(recordServiceUrl + '/record/ranking/' + user);

Check warning

Code scanning / SonarCloud

Server-side requests should not be vulnerable to forging attacks Medium

Change this code to not construct the URL from user-controlled data. See more on SonarCloud
try {
const lang = req.params.lang.toString();
// Forward the question request to the quetion service
const questionResponse = await axios.get(questionServiceUrl+'/questions/' + lang);
const questionResponse = await axios.get(questionServiceUrl+'/questions/' + lang.toString());

Check warning

Code scanning / SonarCloud

Server-side requests should not be vulnerable to forging attacks Medium

Change this code to not construct the URL from user-controlled data. See more on SonarCloud
Copy link

sonarqubecloud bot commented Apr 22, 2024

@Mister-Mario Mister-Mario requested a review from uo289267 April 22, 2024 18:02
Copy link
Contributor

@uo289267 uo289267 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cookies are now implemented 👌🍪

@uo289267 uo289267 merged commit 4449563 into master Apr 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users enhancenment
2 participants