Merge pull request #146 from Arquisoft/fix-quality-gate

fix quality gate
Arquisoft · May 6, 2024 · 1deb7b8 · 1deb7b8
2 parents 9eee00b + 478d4ab
commit 1deb7b8
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/game/groupservice/GroupController.js b/game/groupservice/GroupController.js
@@ -136,7 +136,7 @@ let GroupController = {
 
 async function getGroupByName(name) {
     try {
-        const group = await Group.findOne({ groupName: name });
+        const group = await Group.findOne({ groupName: name.toString() });
         if (!group) {
           throw new Error('This group does not exist');
         }

diff --git a/game/qgservice/QGController.js b/game/qgservice/QGController.js
@@ -79,7 +79,7 @@ let QGController = {
             const { ids } = req.body;
             const questions = [];
             for (const id of ids) {
-                const question = await Question4Answers.find({uuid: id})
+                const question = await Question4Answers.find({uuid: id.toString()})
                 questions.push(question);
             }
             res.json(questions);

diff --git a/game/qgservice/generatorLogic/MathQuestions.js b/game/qgservice/generatorLogic/MathQuestions.js
@@ -37,11 +37,11 @@ function generateRandomMathQuestion() {
     };
   }
 
-  async function createMathQuestions(numberOfQuestions, lang) {
+  async function createMathQuestions(numberOfQuestions) {
     const questions = [];
 
     for (let i = 0; i < numberOfQuestions; i++) {
-      const mathQuestion = generateRandomMathQuestion(lang);
+      const mathQuestion = generateRandomMathQuestion();
       questions.push(mathQuestion);
     }
 

diff --git a/sonar-project.properties b/sonar-project.properties
@@ -11,7 +11,7 @@ sonar.language=js
 sonar.projectName=wiq_en2a
 
 sonar.coverage.exclusions=**/*.test.js
-sonar.sources=webapp/src/components,users/authservice,users/userservice,gatewayservice,game/gameservice,game/groupservice,game/qgservice,multiplayerservice
+sonar.sources=webapp/src/components,users/authservice,users/userservice,gatewayservice,game/gameservice,game/groupservice,game/qgservice
 sonar.sourceEncoding=UTF-8
 sonar.exclusions=node_modules/**
 sonar.javascript.lcov.reportPaths=**/coverage/lcov.info