Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the webapp tests #156

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Fix the webapp tests #156

merged 5 commits into from
Apr 2, 2024

Conversation

jjgancfer
Copy link
Contributor

This PR should fix the webapp tests that do not pass since #145.

@jjgancfer jjgancfer added frontend 👁️ Frontend issue testing 🧪 Regarding testing ASAP 🚨 Urgent issue labels Apr 2, 2024
@jjgancfer jjgancfer added this to the Third delivery milestone Apr 2, 2024
@jjgancfer jjgancfer self-assigned this Apr 2, 2024
@jjgancfer jjgancfer linked an issue Apr 2, 2024 that may be closed by this pull request
Fix tests #155
Closed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
65.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@jjgancfer jjgancfer changed the title Fix to the webapp tests Fix the webapp tests Apr 2, 2024
gony02
gony02 approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@gony02 gony02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@UO283615 UO283615 merged commit f0a3afd into develop Apr 2, 2024
1 of 2 checks passed
@jjgancfer jjgancfer deleted the fix/webapp-tests branch April 4, 2024 21:26
@jjgancfer jjgancfer mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiorodriguezgarcia sergiorodriguezgarcia sergiorodriguezgarcia approved these changes

@gony02 gony02 gony02 approved these changes

Assignees

@jjgancfer jjgancfer

Labels
ASAP 🚨 Urgent issue frontend 👁️ Frontend issue testing 🧪 Regarding testing
Projects
None yet
Milestone
Third delivery
Development

Successfully merging this pull request may close these issues.

Fix tests
4 participants
@jjgancfer @gony02 @sergiorodriguezgarcia @UO283615