Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding tests to the new impl. of Game #202

Closed
wants to merge 4 commits into from
Closed

feat: Adding tests to the new impl. of Game #202

wants to merge 4 commits into from

Conversation

sergiorodriguezgarcia
Copy link
Contributor

@sergiorodriguezgarcia sergiorodriguezgarcia commented Apr 8, 2024 •
edited by jjgancfer
Loading

This contains the new tests for the new version of Game.

@sergiorodriguezgarcia sergiorodriguezgarcia added this to the Third delivery milestone Apr 8, 2024
@sergiorodriguezgarcia sergiorodriguezgarcia self-assigned this Apr 8, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
32.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@sergiorodriguezgarcia sergiorodriguezgarcia mentioned this pull request Apr 8, 2024
Closed
@jjgancfer jjgancfer self-requested a review April 9, 2024 01:29
jjgancfer
jjgancfer requested changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@jjgancfer jjgancfer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests don't seem to work. Sure, they appear to pass, but if you actually check the logs they do fail.

@gony02 gony02 closed this Apr 14, 2024
@sergiorodriguezgarcia sergiorodriguezgarcia deleted the fix/webapp/test branch April 19, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjgancfer jjgancfer jjgancfer requested changes

@GOLASOOO GOLASOOO GOLASOOO approved these changes

Assignees

@sergiorodriguezgarcia sergiorodriguezgarcia

Labels
frontend 👁️ Frontend issue
Projects
None yet
Milestone
Final presentation
Development

Successfully merging this pull request may close these issues.
5 participants
@sergiorodriguezgarcia @jjgancfer @GOLASOOO @gony02 @UO283615