Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS enablement #224

Merged
merged 21 commits into from
Apr 12, 2024
Merged

HTTPS enablement #224

merged 21 commits into from
Apr 12, 2024

Conversation

jjgancfer
Copy link
Contributor

@jjgancfer jjgancfer commented Apr 11, 2024

This PR enables HTTPS by default in both webapp (port 443) and API (port 8443). It also disables HTTP in both; deploying locally for testing purposes should be as easy as commenting lines 14-18 of the api/src/main/resources/application.properties file for the API and with no changes for the webapp.

@jjgancfer jjgancfer added enhancement 🆕 New feature or request backend ⚙️ Backend issue frontend 👁️ Frontend issue labels Apr 11, 2024
@jjgancfer jjgancfer added this to the Final presentation milestone Apr 11, 2024
@jjgancfer jjgancfer requested review from gony02 and Toto-hitori April 11, 2024 18:27
@jjgancfer jjgancfer self-assigned this Apr 11, 2024
@jjgancfer jjgancfer linked an issue Apr 11, 2024 that may be closed by this pull request
Copy link

Copy link
Contributor

@gony02 gony02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done.

@Toto-hitori Toto-hitori merged commit e697941 into develop Apr 12, 2024
2 checks passed
@jjgancfer jjgancfer deleted the feat/https branch April 16, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend ⚙️ Backend issue enhancement 🆕 New feature or request frontend 👁️ Frontend issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable HTTPS in both API and webapp and HTTP/2 in the latter
3 participants