Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-refreshing not handling correctly page updates #257

Merged
merged 4 commits into from
Apr 21, 2024

Conversation

jjgancfer
Copy link
Contributor

This PR should fix a bug regarding page refresh when a game is running.

@jjgancfer jjgancfer added bug 🐛 Something isn't working frontend 👁️ Frontend issue ASAP 🚨 Urgent issue labels Apr 20, 2024
@jjgancfer jjgancfer added this to the Final presentation milestone Apr 20, 2024
@jjgancfer jjgancfer requested review from gony02 and Toto-hitori April 20, 2024 10:07
@jjgancfer jjgancfer self-assigned this Apr 20, 2024
Copy link
Contributor

@gony02 gony02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👏

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove console.log("pepe") pls

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@GOLASOOO GOLASOOO merged commit e611792 into develop Apr 21, 2024
1 of 2 checks passed
@jjgancfer jjgancfer deleted the fix/webapp/game-refresh-page branch April 22, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASAP 🚨 Urgent issue bug 🐛 Something isn't working frontend 👁️ Frontend issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants