Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deployment Github actions, docker compose for Spring API and code cleaning #50

Merged
merged 5 commits into from
Feb 20, 2024

Conversation

Toto-hitori
Copy link
Contributor

@Toto-hitori Toto-hitori commented Feb 20, 2024

  • Some code has been cleaned
  • Autowired annotations were removed
  • New Github actions were created for the SpringBoot API and the PostgreSQL database.
  • Old Github actions were removed.
  • New Github secrets were created and they should be added

@Toto-hitori Toto-hitori changed the title feat: add deployment Github actions and docker compose for Spring API feat: deployment Github actions, docker compose for Spring API and code cleaning Feb 20, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@jjgancfer jjgancfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have deleted the deployment for the webapp. but I intended to mess a little with it anyway so I can restore it myself. Good work.

Copy link
Contributor

@UO283615 UO283615 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I will merge it, I did not know about the @requiredargsconstructor seems very handy.

@UO283615 UO283615 merged commit 42e1499 into develop Feb 20, 2024
2 checks passed
@UO283615 UO283615 deleted the feat/api/deployment-ready branch February 20, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants