Merge branch 'develop_samuel' into develop-deploy

Arquisoft · Apr 26, 2024 · 620cb67 · 620cb67
2 parents a409b17 + 0cec2c1
commit 620cb67
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/users/routes/user-routes.js b/users/routes/user-routes.js
@@ -588,12 +588,14 @@ router.get('/statistics/:username', async (req,res) => {
                 }
             });
 
-            const hasCommonGroup = userGroups.some(userGroup => {
-                return loggedUserGroups.some(loggedUserGroup => loggedUserGroup.groupName === userGroup.groupName);
-            });
-
-            if(!hasCommonGroup){
-                return res.status(403).json({ error: 'You are not allowed to see this user statistics' });
+            if (loggedUserGroups.length != 0 && userGroups != 0){
+                const hasCommonGroup = userGroups.some(userGroup => {
+                    return loggedUserGroups.some(loggedUserGroup => loggedUserGroup.groupName === userGroup.groupName);
+                });
+
+                if(!hasCommonGroup){
+                    return res.status(403).json({ error: 'You are not allowed to see this user statistics' });
+                }
             }
         }