Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating Backgrounds and their Testing #334

Merged
merged 2 commits into from
Apr 28, 2024
Merged

Integrating Backgrounds and their Testing #334

merged 2 commits into from
Apr 28, 2024

Conversation

PBC003
Copy link
Contributor

@PBC003 PBC003 commented Apr 27, 2024

No description provided.

@PBC003 PBC003 added webapp🌐 Related to the front-end testing🔧 Actions taken to verify and validate quality of the tasks labels Apr 27, 2024
@PBC003 PBC003 added this to the Deliverable IV milestone Apr 27, 2024
@PBC003 PBC003 self-assigned this Apr 27, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
30.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

uo288543
uo288543 reviewed Apr 27, 2024
View reviewed changes
Copy link
Contributor

@uo288543 uo288543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would ignore duplicated code, it's just 20 lines.

@uo289689 uo289689 self-requested a review April 28, 2024 07:19
@uo289689 uo289689 merged commit 5b0bc95 into develop Apr 28, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uo288543 uo288543 uo288543 approved these changes

@and1na and1na and1na approved these changes

@alagoconde alagoconde alagoconde approved these changes

@uo289689 uo289689 uo289689 approved these changes

@uo288347 uo288347 uo288347 approved these changes

@PabloGOP PabloGOP Awaiting requested review from PabloGOP

Assignees

@PBC003 PBC003

Labels
testing🔧 Actions taken to verify and validate quality of the tasks webapp🌐 Related to the front-end
Projects
None yet
Milestone
Deliverable IV
Development

Successfully merging this pull request may close these issues.
6 participants
@PBC003 @uo288347 @uo289689 @alagoconde @uo288543 @and1na