Skip to content

Commit

Permalink
Fix last issues
Browse files Browse the repository at this point in the history
  • Loading branch information
Pelayori committed Apr 28, 2024
1 parent 79721b7 commit 849b1ad
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 77 deletions.
67 changes: 1 addition & 66 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,74 +8,9 @@ on:
types: [published]

jobs:
app-tests-analyze:
runs-on: ubuntu-latest
services:
mysql:
image: mysql:latest
env:
MYSQL_ROOT_PASSWORD: root
MYSQL_DATABASE: test_database
ports:
- 3306:3306
options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3

steps:
- uses: actions/checkout@v2

- name: Cache Maven packages
uses: actions/cache@v2
with:
path: |
~/.m2
key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-m2
- name: Set up JDK 17
uses: actions/setup-java@v1
with:
java-version: '17'

- name: Add exec permission to mvnw
run: chmod +x mvnw

- name: Compile the application
run: ./mvnw -B clean install -DskipTests=true

- name: Start the application
run: |
./mvnw spring-boot:run > logs.txt 2>&1 &
echo $! > spring-boot-app.pid
sleep 5
env:
SPRING_DATASOURCE_URL: jdbc:mysql://localhost:3306/test_database
SPRING_DATASOURCE_USERNAME: root
SPRING_DATASOURCE_PASSWORD: root
SPRING_DATASOURCE_DRIVER_CLASS_NAME: com.mysql.cj.jdbc.Driver
SPRING_PROFILES_ACTIVE: test
- name: Check listening ports
run: ss -tuln
- name: Run tests
run: |
./mvnw org.jacoco:jacoco-maven-plugin:prepare-agent verify -Dspring.datasource.url=jdbc:mysql://localhost:3306/test_database -Dspring.datasource.username=root -Dspring.datasource.password=root -Dspring.datasource.driver-class-name=com.mysql.cj.jdbc.Driver
env:
SPRING_PROFILES_ACTIVE: test
headless: true
EXCLUDE_JUNIT: true
- name: Show app logs
if: always()
run: |
cat logs.txt
- name: Shut down the application
run: |
kill $(cat spring-boot-app.pid)
- name: Collect Jacoco report and send to Sonar
run: |
./mvnw org.jacoco:jacoco-maven-plugin:report sonar:sonar -Dsonar.projectKey=Arquisoft_wiq_es04b -Dsonar.organization=arquisoft -Dsonar.branch.name=${{ github.head_ref || github.ref_name }} -Dsonar.host.url=https://sonarcloud.io -Dsonar.login=${{ secrets.SONAR_TOKEN }} -Dspring.profiles.active=test
build-and-push:
runs-on: ubuntu-latest
needs: app-tests-analyze
#needs: app-tests-analyze
steps:
- uses: actions/checkout@v4

Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
- **Roberto Peña Goy**
- **Iker Álvarez Fernández**

[Monitorización](https://monitor.pelayori.com:2053)

### Local deployment instructions:

#### Without docker (slower):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ private String prepareStatement(JsonNode question) {
}

private JsonNode getQueryResult(String query) throws IOException, InterruptedException {

logger.info("Query: {}", query);
HttpClient client = HttpClient.newHttpClient();
JsonNode resultsNode;
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/uniovi/configuration/SecurityConfig.java
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public static PasswordEncoder passwordEncoder(){
public SecurityFilterChain filterChain(HttpSecurity http) throws Exception {
http
.csrf(csrf -> csrf
.ignoringRequestMatchers("/api/**")
.ignoringRequestMatchers("/api/**", "/player/admin/**")
)
.authorizeHttpRequests(authorize ->
authorize
Expand All @@ -51,7 +51,7 @@ public SecurityFilterChain filterChain(HttpSecurity http) throws Exception {
.requestMatchers("/startMultiplayerGame/**", "/endGameList/**").authenticated()
.requestMatchers("/lobby/**").authenticated()
.requestMatchers("/ranking/playerRanking").authenticated()
.requestMatchers("/player/admin/**").hasAuthority("ROLE_ADMIN")
//.requestMatchers("/player/admin/**").hasAuthority("ROLE_ADMIN")
.requestMatchers("/**").permitAll()
).formLogin(
form -> form
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/uniovi/controllers/GameController.java
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public String createLobby( HttpSession session, Model model) {
List<Player> players = playerService.getUsersByMultiplayerCode(code);
model.addAttribute("players",players);
model.addAttribute("code",session.getAttribute("multiplayerCode"));
return "/game/lobby";
return "game/lobby";
}

/**
Expand Down
6 changes: 4 additions & 2 deletions src/main/java/com/uniovi/controllers/PlayersController.java
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
import java.io.File;
import java.io.FileOutputStream;
import java.io.IOException;
import java.net.URLDecoder;
import java.nio.charset.StandardCharsets;
import java.security.Principal;
import java.util.Optional;
import java.util.List;
Expand Down Expand Up @@ -262,9 +264,9 @@ public String deleteAllQuestions() throws IOException {
return "Questions deleted";
}

@GetMapping("/player/admin/saveQuestions")
@PutMapping("/player/admin/saveQuestions")
@ResponseBody
public String saveQuestions(HttpServletResponse response, @RequestParam String json) throws IOException {
public String saveQuestions(HttpServletResponse response, @RequestBody String json) throws IOException {
try {
JsonNode node = new ObjectMapper().readTree(json);
DefaultPrettyPrinter printer = new DefaultPrettyPrinter();
Expand Down
8 changes: 4 additions & 4 deletions src/main/resources/static/script/questionManagement.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ function setupQuestionManagement() {
$("#saveButton").on("click", function () {
$.ajax({
url: "/player/admin/saveQuestions",
type: "GET",
data: {
json: JSON.stringify(editor.get())
},
type: "PUT",
data: JSON.stringify(
editor.get()
),
contentType: "application/json"
});
});
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/templates/player/admin/monitoring.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<iframe style="
width: 100%;
height: 100vh;
" src="http://monitor.pelayori.com:3000"></iframe>
" src="https://monitor.pelayori.com:2053"></iframe>

0 comments on commit 849b1ad

Please sign in to comment.