Skip to content

Commit

Permalink
agregar al env las variables
Browse files Browse the repository at this point in the history
  • Loading branch information
bidof committed Apr 10, 2024
1 parent 897b620 commit 0a0cf99
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ jobs:
password: ${{ secrets.GITHUB_TOKEN }}
registry: ghcr.io
workdir: roomservice
buildargs: REACT_APP_API_URI

docker-push-webapp:
name: Push webapp Docker Image to GitHub Packages
Expand All @@ -84,7 +85,7 @@ jobs:
password: ${{ secrets.GITHUB_TOKEN }}
registry: ghcr.io
workdir: webapp
buildargs: REACT_APP_API_URI
buildargs: REACT_APP_API_URI,REACT_APP_SOCKET_URI

docker-push-questionservice:
name: Push question service Docker Image to GitHub Packages
Expand Down
4 changes: 3 additions & 1 deletion roomservice/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ COPY package*.json ./

# Install app dependencies
RUN npm install

#OBTENER LA RAVILE PAR QUE SOCKET PERMITA CONEX
ARG REACT_APP_API_URI
ENV REACT_APP_API_URI=$REACT_APP_API_URI
# Copy the app source code to the working directory
COPY . .

Expand Down
3 changes: 2 additions & 1 deletion webapp/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ RUN npm install

ARG REACT_APP_API_URI
ENV REACT_APP_API_URI=$REACT_APP_API_URI

ARG REACT_APP_SOCKET_URI
ENV REACT_APP_SOCKET_URI=$REACT_APP_SOCKET_URI
#Create an optimized version of the webapp
RUN npm run build
RUN npm install serve
Expand Down

0 comments on commit 0a0cf99

Please sign in to comment.