Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Manejo de tiempo agotado con modal #96

Closed
wants to merge 69 commits into from
Closed

✨ Manejo de tiempo agotado con modal #96

wants to merge 69 commits into from

Conversation

UO285240
Copy link

@UO285240 UO285240 commented Apr 7, 2024

No description provided.

labra and others added 30 commits January 22, 2024 13:12
Fixing some not updated info in README.md and removing unnecesary commands from the actions
Adding the .env to the service deployment
This reverts commit dbaea69, reversing
changes made to fa9aec3.
Little fixes into the README.md and deploy.yml to tear-down the containers correctly
- Included an openapi.yaml file with the v0.2.0 of the specification
- Some changes in the gateway.js to create the swagger sever
- Added --pull always option to the README
- Reemplace the host IP for production in the specification file 
- Changed the routes to avoid Fnotfound during the E2E test suite execution
app.get('/getgamehistory/:username', async (req, res) => {
try {
const username = req.params.username;
const userResponse = await axios.get(`${userServiceUrl}/getgamehistory/${username}`);

Check warning

Code scanning / SonarCloud

Server-side requests should not be vulnerable to forging attacks

<!--SONAR_ISSUE_KEY:AY66SO0pbroSQlYRTrNW-->Change this code to not construct the URL from user-controlled data. <p>See more on <a href="https://sonarcloud.io/project/issues?id=Arquisoft_wiq_es2b&issues=AY66SO0pbroSQlYRTrNW&open=AY66SO0pbroSQlYRTrNW&pullRequest=96">SonarCloud</a></p>
@baraganio baraganio closed this Apr 7, 2024
Copy link

sonarqubecloud bot commented Apr 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
10.8% Coverage on New Code (required ≥ 80%)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants