Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency converter in cpp #84

Merged
merged 6 commits into from
Jul 4, 2023
Merged

Conversation

CodeCinnamon001
Copy link
Contributor

Assigned Issue Number #16 { if does not exist then create one }

#7

Language Opted ?

C/C++

Number of files added or updated ?

3

Checklist

  • [ ✓] I've read the contribution guidelines.
  • [ ✓ ] I've referred the correct issue number.
  • [ ✓] I've fill up this entire template correctly.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the project 🤓

Our developers will respond you as soon as possible 🤓 . Any questions let us know.

@Arsenic-ATG Arsenic-ATG added the New-Automation This pull request is focussed on adding a new Automation to the repo label Jul 4, 2023
Copy link
Owner

@Arsenic-ATG Arsenic-ATG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, the program itself looks good to me
There are some minor typos in readme I see that you might wanna look at and after that we can finally merge it.

Automations/currency-converter/README.md Outdated Show resolved Hide resolved
Automations/currency-converter/README.md Outdated Show resolved Hide resolved
Automations/currency-converter/README.md Outdated Show resolved Hide resolved
@CodeCinnamon001
Copy link
Contributor Author

Thanks for contributing, the program itself looks good to me There are some minor typos in readme I see that you might wanna look at and after that we can finally merge it.

@CodeCinnamon001
Copy link
Contributor Author

Actually English is my second language so i dont know it pretty well. i have committed the changes that you have suggested in readme.md
Thanks
-CodeCinnamon001

@Arsenic-ATG
Copy link
Owner

Thank you for choosing this project to contribute to
merging now

@Arsenic-ATG Arsenic-ATG merged commit de3d156 into Arsenic-ATG:master Jul 4, 2023
@Arsenic-ATG
Copy link
Owner

Actually English is my second language so i dont know it pretty well. i have committed the changes that you have suggested in readme.md Thanks -CodeCinnamon001

not a problem
English is not my first language either, I use tools like codespell ( https://github.com/codespell-project/codespell ) to detect common typos in documentations and even in code files 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New-Automation This pull request is focussed on adding a new Automation to the repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants