Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] Bloom, Glare and exposure from TauCeti #605

Conversation

QuacksQ
Copy link
Contributor

@QuacksQ QuacksQ commented Jul 15, 2024

About The Pull Request

This pr ports bloom, glare and exposure from TauCeti.
In moderation these effects look really good and can add a lot of soul to the server and the lights we use to brighten the ship.
Currently on the pr the effects are set to low but this can be changed.
Verbs to toggle these effects are included.
(This verb has been commented out because I believe these effects should be applied to all players so everyone has the same experience visually)

I may have commited several crimes against humanity to patch this into a running state.
Looks cool though so worth it :)

Original pr's:

How Does This Help Gameplay?

IMMERSION OH GOD THE IMMERSION JUST LOOK AT IT!!!!!

How Does This Help Roleplay?

Insert joke about immersion here.

Proof of Testing

Screenshots/Videos
2024-07-15.16-08-04.mp4

Changelog

🆑
add: Added bloom, glare and exposure effects to lights!
/:cl:

@github-actions github-actions bot added Feature How I broke the server in one easy step! Port "So I saw this cool thing-" Sprites I like pretty things. UI Also known as "I like lagspikes, so I added TGUI to your TGUI". labels Jul 15, 2024
@QuacksQ
Copy link
Contributor Author

QuacksQ commented Jul 15, 2024

Cant wait for lints to start yelling at me

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale "Anyone home?" label Jul 23, 2024
@github-actions github-actions bot closed this Jul 31, 2024
@RimiNosha RimiNosha removed the Stale "Anyone home?" label Aug 3, 2024
@RimiNosha RimiNosha reopened this Aug 3, 2024
@QuacksQ QuacksQ marked this pull request as ready for review October 5, 2024 16:47
@QuacksQ
Copy link
Contributor Author

QuacksQ commented Oct 5, 2024

AFTER

image

image-1

image

image-1

image

@QuacksQ
Copy link
Contributor Author

QuacksQ commented Oct 5, 2024

BEFORE

image

image-1

image

image-1

image

@QuacksQ
Copy link
Contributor Author

QuacksQ commented Oct 5, 2024

image

@QuacksQ QuacksQ merged commit 06187e9 into Artea-Station:master Oct 5, 2024
17 checks passed
Artea-Station-Bot added a commit that referenced this pull request Oct 5, 2024
@QuacksQ QuacksQ deleted the help-I-dont-speak-russian(Lighting-update) branch October 6, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature How I broke the server in one easy step! Port "So I saw this cool thing-" Sprites I like pretty things. UI Also known as "I like lagspikes, so I added TGUI to your TGUI".
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants