New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMAKE_UNITY_BUILD usage #738

Merged

ArthurSonzogni merged 2 commits into ArthurSonzogni:main from ClausKlein:feature/fix-unity-build

Aug 28, 2023

Contributor

ClausKlein commented Aug 28, 2023 •

edited

Loading

Add missing include guard.

This fix cpp-best-practices/cmake_template#64


          Fix CMAKE_UNITY_BUILD usage

e186dc8

Add missing include guard.

ArthurSonzogni force-pushed the feature/fix-unity-build branch from 9ab2a7a to e186dc8 Compare

August 28, 2023 19:36


          Add comment.

00da210

ArthurSonzogni merged commit dd6a5d3 into ArthurSonzogni:main

6 checks passed

Owner

ArthurSonzogni commented Aug 28, 2023

Thanks! I remember Chromium has some options for this, I couldn't imagine cmake has options like this.

I updated the patch to avoid pragma, added comments, and updated the CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet