Moving from ini to toml with config #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturOle
added a commit
that referenced
this pull request
Nov 18, 2024
* Moving from ini to toml with config (#28) * Moving from ini file to toml * Correcting tests and adjusting code for toml-based shared DTO object * Version bump * logging in exeption handling set to error level * Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ini file was processed by code prepared "at the spot" and was not in any case reliable. I decided to use toml format as we already have the pyproejct.toml in the project.
There was a lot of "doing things twice" with the previous version. Currently, the variables needed for the OCR and databases as well as eventual new config information is available from the level of EnvInterface class. The data is shared for all instances of this class and provide easy access to these resources without need of passing as variables, additional file reads or initilization.