Contain all display init logic within display.c #429
+24
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@asdfugil could you please test this on an iDevice to make sure it didn't break anything? |
asdfugil
suggested changes
Dec 21, 2024
Display handling was spread across main.c, utils.c and display.c with the addition of iDevice support. Condense all of this functionality into display.c. This also fixes a regression introduced in 869d2ae ("Skip over features unsupported in A7-A11 SoCs."), which caused devices using dcpext to skip DCP initialisation. Signed-off-by: James Calligeros <[email protected]>
chadmed
force-pushed
the
display-fixes
branch
from
b0fc85e to
6229a1b
Compare
asdfugil
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #428. Not sure if the changes to
display_get_config()are the right thing to do here.