Add branch deletion exceptions #194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzyng83209
requested changes
Jul 1, 2024
There was a problem hiding this comment.
I'm not a huge fan of this change because its hardcoding branch names that may or may not be protected. You can deploy this as a temporary fix to unblock IT or deploy a version of SGTM without #193 but I'm going to talk to IT to see if we can find a better solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#193 started deleting "main" branches when PRs were being made from that branch. Add some logic to ignore deletion logic for certain branches. We could maybe make this configurable through an env variable but not sure how useful that would be
Asana tasks:
https://app.asana.com/0/1202309366996843/1207707608547616/f
Test Plan
Pull Request synchronized with Asana task