Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #83

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Conversation

ChrisJefferson
Copy link
Contributor

@ChrisJefferson ChrisJefferson commented Mar 30, 2024

Make the examples closed to compiling 'as is'.

Changes:

  • Change debug! (which isn't imported) with println!. This seems reasonable for a little demo?
  • Remove imports of database in the "in memory" example (which is the one I wanted to cut+paste), as they aren't needed and also don't work without adding another package?

With these two tiny changes, the 'in memory' example does now build and run as is.

make the examples compile 'as is'.

Changes:

* Change `debug!` (which isn't imported) with `println!`. Obviously someone might want to do logging.
* Remove imports of database in the "in memory" example (which is the one I wanted to cut+paste), as they aren't needed and don't work if I disable postgres (which I want to do, as I don't have it installed).

With these two tiny changes, the 'in memory' example does now build and run as is.
Copy link
Member

@genusistimelord genusistimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thank you. debug! was for usage with the log crate but you are correct not everyone will be using it even though I think they should.

@genusistimelord genusistimelord merged commit 4625ee3 into AscendingCreations:main Mar 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants