Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement bb8-redis #92

Merged
merged 1 commit into from
Oct 4, 2024
Merged

feat: implement bb8-redis #92

merged 1 commit into from
Oct 4, 2024

Conversation

bkhalifeh
Copy link

No description provided.

genusistimelord
genusistimelord approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@genusistimelord genusistimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add this in, but is there any actual issues with using redis pool? just curious why bb8?
Anyways Thank you.

@genusistimelord genusistimelord merged commit e0428c9 into AscendingCreations:main Oct 4, 2024
3 checks passed
@bkhalifeh
Copy link
Author

I will add this in, but is there any actual issues with using redis pool? just curious why bb8? Anyways Thank you.

Hello, first of all, thanks for the great package you wrote.
Actually, I used bb8-redis in my project, which is why I’m submitting this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genusistimelord genusistimelord genusistimelord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkhalifeh @genusistimelord @mlmond