Merge pull request #192 from klingbolt/bool_fix

Fixed boolean stringification
AsherGlick · Oct 31, 2023 · 4671c02 · 4671c02
2 parents 73ae206 + 0e4d980
commit 4671c02
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/xml_converter/intigration_tests/expected_outputs/xml_can_fade_invalid/xml_file.xml b/xml_converter/intigration_tests/expected_outputs/xml_can_fade_invalid/xml_file.xml
@@ -3,6 +3,6 @@
 </MarkerCategory>
 
 <POIs>
-<POI  CanFade="false" Type="mycategory" IconFile="texture.png" MapID="50" XPos="169.809998" YPos="210.649994" ZPos="215.830002"/>
+<POI  Type="mycategory" IconFile="texture.png" MapID="50" XPos="169.809998" YPos="210.649994" ZPos="215.830002"/>
 </POIs>
 </OverlayData>
diff --git a/xml_converter/src/attribute/bool.cpp b/xml_converter/src/attribute/bool.cpp
@@ -40,7 +40,7 @@ void xml_attribute_to_bool(
 // Converts a bool into a fully qualified xml attribute string.
 ////////////////////////////////////////////////////////////////////////////////
 string bool_to_xml_attribute(const string& attribute_name, const bool* value) {
-    if (value) {
+    if (*value) {
         return " " + attribute_name + "=\"true\"";
     }
     else {