Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SOTO Update] Shifted the burrito button to the right #156

Merged
merged 8 commits into from
Sep 20, 2023

Conversation

klingbolt
Copy link
Contributor

Adjusted the button to account for the new icon

@AsherGlick
Copy link
Owner

AsherGlick commented Aug 25, 2023

Cant seem to click the burrito icon anymore
Screenshot from 2023-08-24 20-08-11

The item that should be moved is the parent control node for the icon and the button.

This change will need to also update the code probably so the mouse passthrough is centered on the new icon location, I dont remember if that is automatic or not.

Spatial.tscn Outdated
margin_right = 314.348
margin_bottom = 32.0
margin_left = 321.348
margin_top = 4.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You took this off of the texture, now it does not line up to the top of the screen.
Screenshot from 2023-08-24 21-12-58

Copy link
Owner

@AsherGlick AsherGlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You took this off of the texture, now it does not line up to the top of the screen.

var bottom_corner := Vector2(314, 32)
var menu_button = $Control/GlobalMenuButton
var top_corner = menu_button.get_position()
var bottom_corner = menu_button.get_position() + menu_button.get_size()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By changing the values here to the properties the numbers come from, any more changes to the icons will be updated in the passthrough

margin_right = 27.0
margin_bottom = 32.0
margin_right = 29.0
margin_bottom = 30.0
__meta__ = {
"_edit_use_anchors_": false
}

[node name="EditorQuckPanel" type="PanelContainer" parent="Control/GlobalMenuButton"]
visible = false
margin_left = 32.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that the margin besides the left margin does not make a difference if the margin is less than the size. Thus, removing the unnecessary ones

@klingbolt klingbolt requested a review from AsherGlick August 25, 2023 16:16
@AsherGlick
Copy link
Owner

Screenshot from 2023-08-28 18-55-11
I think the icon is off still horizontally. My measurements say the icons are 32px apart

@AsherGlick
Copy link
Owner

Screenshot from 2023-08-28 18-59-33
Looks like the height is still 1px off

Spatial.tscn Outdated Show resolved Hide resolved
@AsherGlick AsherGlick merged commit 9f6ae70 into AsherGlick:master Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants