Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf only create whats needed #165

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

AsherGlick
Copy link
Owner

Reduced from an exponential growth, and a random metric of:

The taco parse function took 2476 milliseconds to run
The protobuf write function took 37937 milliseconds to run

to a more linear growth, and the same metric of:

The taco parse function took 2494 milliseconds to run
The protobuf write function took 6735 milliseconds to run

The new system is now much more linear with output size as the entire sum of all the markerpacks are not being copied in memory for each output file anymore.

Base automatically changed from string_hierarchy to xml_converter September 27, 2023 22:37
@AsherGlick AsherGlick merged commit 32ccac8 into xml_converter Sep 27, 2023
@AsherGlick AsherGlick deleted the protobuf_only_make_whats_needed branch September 27, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant