Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating Simpler Nested Proto Parse Templates #173

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Creating Simpler Nested Proto Parse Templates #173

merged 1 commit into from
Oct 9, 2023

Conversation

AsherGlick
Copy link
Owner

The previous logic had duplicated code chunks. The new logic is much more flexible and unifies the template branches to remove duplicate chunks.

@AsherGlick
Creating Simpler Nested Proto Parse Templates
031d6a4 
The previous logic had duplicated code chunks. The new logic is much more flexible and unifies the template branches to remove duplicate chunks.
Base automatically changed from remove_doc_type_to_cpp_type to xml_converter October 9, 2023 03:06
@AsherGlick AsherGlick merged commit bd91f94 into xml_converter Oct 9, 2023
12 checks passed
@AsherGlick AsherGlick deleted the better_nested_proto_parse_logic branch October 9, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klingbolt klingbolt klingbolt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AsherGlick @klingbolt