Adding zero cost wrappers to the proto serializers #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not entirely nessasary, they are all identify functions. However adding them means that we dont need to differentiate between the scalar/primitive types and instead we can just treat all types generally the same.
klingbolt
approved these changes
Oct 9, 2023
Base automatically changed from
better_nested_proto_assignment
to
xml_converter
October 9, 2023 03:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not entirely necessary, they are all identify functions. However adding them means that we dont need to differentiate between the scalar/primitive types and instead we can just treat all types generally the same.