Splitting the cpp code generator out of the rest of the generators #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably should have been how it was done originally, but it was easier to just make the code generator a part of the existing generator. But now the generators are over a thousand lines long so lets just start splitting them out to better guarantee low coupling.
This is a big diff, but it is almost entirely copy/paste. The only times it is not copy paste is when we are removing the
self
variables, instead passingdata
in as an argument, and unindenting the code now that it is no longer a class method and just a normal function.Functions that were more utility based functions and not directly tied to the cpp generator, maybe even needed for both generators, were moved to
util.py
so they could be included in both places at once.