Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting the cpp code generator out of the rest of the generators #196

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

AsherGlick
Copy link
Owner

This probably should have been how it was done originally, but it was easier to just make the code generator a part of the existing generator. But now the generators are over a thousand lines long so lets just start splitting them out to better guarantee low coupling.

This is a big diff, but it is almost entirely copy/paste. The only times it is not copy paste is when we are removing the self variables, instead passing data in as an argument, and unindenting the code now that it is no longer a class method and just a normal function.

Functions that were more utility based functions and not directly tied to the cpp generator, maybe even needed for both generators, were moved to util.py so they could be included in both places at once.

This probably should have been how it was done originally, but it was easier to just make the code generator a part of the existing generator. But now the generators are over a thousand lines long so lets just start splitting them out to better guarentee low coupling.
Base automatically changed from cohesive_templates to xml_converter November 3, 2023 03:16
@AsherGlick AsherGlick merged commit f49d75c into xml_converter Nov 3, 2023
12 checks passed
@AsherGlick AsherGlick deleted the splitting_codegen_and_docgen branch November 3, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants