Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Proto Tests #205

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Adding Proto Tests #205

merged 1 commit into from
Nov 5, 2023

Conversation

AsherGlick
Copy link
Owner

Finally adding our first protobin tests to make sure the protobin output is valid.

Also...

  • adding protobin output. We were never writing any protbins when not using the split by map id functionality.
  • Icon textures were removed from the tests because they are dubiously required, and more importantly not saved properly yet in the proto.
  • Adding DisplayName to tests because we are no longer writing "name" to the binaries. Additional work will need to go into that issue at another time.
  • Formatted and deduplicated input xml data for tests.
  • Changed the integration diff tool to use unified diffs as a part of a fix for a number of readability issues

Base automatically changed from depricate_proto_category to xml_converter November 5, 2023 23:43
@AsherGlick AsherGlick merged commit 7bffa71 into xml_converter Nov 5, 2023
12 checks passed
@AsherGlick AsherGlick deleted the proto_integration_tests branch November 5, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klingbolt klingbolt klingbolt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AsherGlick @klingbolt