Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated gdscript code to reflect proto changes. #233

Merged
merged 10 commits into from
Dec 29, 2023

Conversation

klingbolt
Copy link
Contributor

Slight change to visibility because of the changes made to category name

Icon.gd Outdated Show resolved Hide resolved
Copy link
Owner

@AsherGlick AsherGlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some things I noticed quickly, we should do a pair review on this though as there are some other things that would be easier to discuss in realtime.

Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Category.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated
@@ -680,7 +680,7 @@ func gen_adjustment_nodes():
print("No category selected")
return

var category = self.currently_active_category.get_metadata(0).category
var category = self.currently_active_category.get_metadata(0).category3d
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3d?

@AsherGlick AsherGlick merged commit d322150 into AsherGlick:xml_converter Dec 29, 2023
6 checks passed
@klingbolt klingbolt deleted the node_visibility branch December 29, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants