Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling xml converter #259

Merged
merged 10 commits into from
Jan 2, 2024

Conversation

klingbolt
Copy link
Contributor

Addressing #80

This PR allows the user to select an xml pack and load the markers into the internal format.

At this state, only one pack can be loaded at a time.

Copy link
Owner

@AsherGlick AsherGlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems to crash on-load in the mistlock with the error
Screenshot from 2023-12-31 19-08-23

Is this caused by the same bug you mentioned was pre-existing? If so we can punt that fix to the next pr.

Spatial.tscn Outdated Show resolved Hide resolved
Spatial.tscn Outdated Show resolved Hide resolved
Spatial.tscn Outdated Show resolved Hide resolved
Spatial.tscn Outdated Show resolved Hide resolved
Spatial.tscn Outdated Show resolved Hide resolved
Spatial.tscn Outdated Show resolved Hide resolved
Spatial.tscn Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
PackDialog.gd Outdated Show resolved Hide resolved
PackDialog.gd Outdated Show resolved Hide resolved
@klingbolt
Copy link
Contributor Author

Code seems to crash on-load in the mistlock with the error Screenshot from 2023-12-31 19-08-23

Is this caused by the same bug you mentioned was pre-existing? If so we can punt that fix to the next pr.

No this looks like something else. Is the file being loaded newly created or an older export? It seems to suggest there is a trail field in the proto with no points.

@AsherGlick
Copy link
Owner

I was able to trigger it to crash on startup when I had no converted markers, but I was also able to convert markers by not launching gw2 and using the burrito menus to convert markers. I converted the turtlepoint-skipbad markers and had the same issue.

I did have other old markers in the same burrito config directory but in a different subfolder. I attempted to remove them and was met with the same issue.

If there are no markers for a given map we probably should not crash, if that bug was introduced in this PR it should be fixed.

@AsherGlick
Copy link
Owner

Screenshot from 2024-01-01 15-17-40
After discussing offline, we will ignore this mistlock issue as it is just bad data. We should not crash on bad data thoguh. However it seems that all marker packs cannot be imported.

PackDialog.gd Outdated Show resolved Hide resolved
Spatial.tscn Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
@AsherGlick AsherGlick merged commit 0d75c75 into AsherGlick:xml_converter Jan 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants