-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added scripts to perform copy-keys operation. #1
base: master
Are you sure you want to change the base?
Conversation
Added a new script taking care of the entire GUI. Things done - GUI, different validations, Key Vault creations as requested with default names. Things NOT done - handling common parameter inputs and GUI inputs together, still using AAD app for token generation, informative comments. |
I have tested quite a bit but do let me know if you come across any failures or scenarios not handled. A bek+kek test case : Src bek vault: testkv05pb Target vault has been deleted, for now. |
|
||
[Parameter(Mandatory = $true, | ||
|
||
HelpMessage="Identifier of the Azure subscription to be used")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identifier?
|
||
[Parameter(Mandatory = $true, | ||
|
||
HelpMessage="Name of the AAD application that will be used to write secrets to KeyVault. A new application with this name will be created if one doesn't exist. If this app already exists, pass aadClientSecret parameter to the script")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From help message: "pass aadClientSecret parameter to the script"
are we suggesting customers to pass aadClientSecret with aadAppName?
|
||
# AAD app wasn't created | ||
|
||
Write-Error "Failed to create AAD app $aadAppName. Please log in to Azure using Connect-AzureRmAccount and try again"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will "Please log in to Azure using Connect-AzureRmAccount and try again" be the only reason for failure?
If so, why don't we checkin in the start and run the flow. If needed, we can even check the subscription context and run then login cmdlet asking for the context.
|
|
Two scripts have been added:
Create-aad-app: Creates a new aad app and secret. Or a new secret for existing aad app
copy-keys: Transfer BEK and wrapped BEK to the other key vault