Link balance items to receipt #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ortolino
reviewed
May 29, 2024
.../main/java/com/github/se/assocify/ui/screens/treasury/accounting/AccountingDetailedScreen.kt
Show resolved
Hide resolved
...va/com/github/se/assocify/ui/screens/treasury/accounting/balance/BalanceDetailedViewModel.kt
Show resolved
Hide resolved
...rc/main/java/com/github/se/assocify/ui/screens/treasury/receiptstab/receipt/ReceiptScreen.kt
Show resolved
Hide resolved
|
ortolino
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The balance items are now correlated with receipts.
When you change the status of a balance items, the status icon is directly changed in the BalanceDetailedScreen and in the ReceiptScreen.
You can no longer change the status of a receipt in the ReceiptScreen. Only the treasurer can do that and it makes sense do that only in Balance.
You can choose to link a receipt to the balance item or not. When you chose not to, you can choose the "No receipt" value and input your own amount. However, if you choose a receipt, the amount will be linked to the amount of the receipt and the status of the balance item will be linked to the status of the receipt.